Re: UFS_GJOURNAL and ufs.ko

On Mon, Dec 18, 2006 at 10:36:13AM -0600, Brooks Davis wrote, and it was proclaimed:
> On Mon, Dec 18, 2006 at 03:39:06PM +0000, Coleman Kane wrote:
> > Hello,
> > 
> > I have noticed (since adding UFS journal support) that the
> > UFS_GJOURNAL option hasn't been added to the ufs.ko kernel
> > module. I've been using this (out of an effort to test as
> > much as possible as KLDs) and every time I upgrade my kernel
> > I must manually add -DUFS_GJOURNAL to the CFLAGS line in
> > its Makefile.
> > 
> > Is there any specific reason why this can't be committed?
> > So far, my experience with GJOURNAL has been great testing
> > it both with journal+fs on the same device as well as on
> > two seperate devices.
> > 
> > It looks like an oversight to me, but I don't want to jump
> > the gun on it if there is some reasonable argument to keep
> > it out "by default".
> 
> UFS_GJOURNAL is not enabled in GENERIC yet so it should not be enabled
> in the module.  At this time more review is needed before it can be
> enabled by default (believe Kirk has been convinced to perform some
> review).  While Pawel's work looks good we need to be very, very careful
> with UFS.  We can't afford to have anything go wrong with our main
> (essentially only) file system.
> 
> -- Brooks

I understand, thanks for the explanation. I'll just maintain it with my
patchset for now.

--
Coleman