Re: New RCorder: abi loaded too late

From: Doug Barton <dougb_at_FreeBSD.org>
Date: Fri, 17 Feb 2006 16:58:09 -0800
Brooks Davis wrote:
> On Fri, Feb 17, 2006 at 03:21:20PM -0800, Doug Barton wrote:
>> Brooks Davis wrote:
>>> On Fri, Feb 17, 2006 at 10:39:53PM +0800, Xin LI wrote:
>>>> Hi,
>>>>
>>>> With the recent rcorder change, we were able to
>>>> start /usr/local/etc/rc.d in the same rcorder pass.  However, because
>>>> abi was started late in the startup process, we have potentially broke
>>>> the services written for older FreeBSD releases, or other operating
>>>> systems, which were written to use rc.d scripts.
>>>>
>>>> Shall we move abi to be started before SERVERS?
>>> Seems fine, I'd recommend:
>>>
>>> # REQUIRE: mountcritremote
>>> # BEFORE: SERVERS
>>>
>>> The current requirement of LOGIN makes no sense.
>> Agreed on the last, but can we modify SERVERS to REQUIRE abi instead? I
>> would prefer not to add new instances of BEFORE in /etc/rc.d without good
>> reason. I'd also vote for REQUIRE syslogd in abi personally, but I won't
>> quibble on that point.
> 
> In the case of pseudo targets, I'm of the opinion that the BEFORE
> statements are more consistent.  I'm not all that thrilled with them in
> general, but IMO inconsistent of use BEFORE and REQUIRE is the biggest
> problem. 

Right. Eventually I'd like to remove as many BEFORE's in the base as we can,
and make the use of REQUIRE consistent, which is why I'd like to avoid
adding new ones. However, I won't quibble on this one either.

> I don't see any logical reason for syslogd to be required.
> kldload doesn't call syslog, I seriously double linux ldconfig does, and
> the abi script will always return success.

Of the things between mountcritremote and SERVERS, that seemed the most
logical choice. On my box it's second to last before savecore, and that
didn't seem to make any sense at all. :)

I won't object to your original suggestion, I just wanted to express a
preference for not adding new BEFORE's. At this time however, what you
suggested may be the best way to go.

Doug

-- 

    This .signature sanitized for your protection
Received on Fri Feb 17 2006 - 23:58:25 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:52 UTC