Re: [PATCH] possible fix for the runtime going backwards warnings

From: Kris Kennaway <kris_at_obsecurity.org>
Date: Wed, 22 Feb 2006 14:32:25 -0500
On Wed, Feb 22, 2006 at 11:01:39AM -0500, John Baldwin wrote:
> On Tuesday 21 February 2006 21:36, Kris Kennaway wrote:
> > On Tue, Feb 21, 2006 at 10:47:04AM -0500, John Baldwin wrote:
> > > The latest round of calcru() changes accidentally changed calccru() to
> > > use the wrong rusage_ext structure (p->p_rux vs p->p_crux) when
> > > calculating usage times for children.  The patch fixes calccru() to use
> > > p->p_crux again.  It also moves the ruadd() in exit1() even later in the
> > > function so that it takes the dying thread's last time slice into
> > > account.  Please test it and let me know if it makes the messages go away
> > > (or if it makes things worse!)  Thanks!
> > >
> > > http://www.FreeBSD.org/~jhb/patches/calccru.patch
> >
> > I think you committed this already, right?
> 
> Yes.
> 
> > I'm still getting calcru spam on the 3 SMP machines that I upgraded
> > with fresh sources:
> 
> Is it more or less than before the patch?  Also, what happens if you just back 
> out the kern_exit.c change?

About the same.

> The pagezero ones are truly odd.  calcru() shouldn't be called for kthreads 
> very often (if at all).  I wonder if your tickrate is changing out from under 
> you.  Try editing sys/i386/i386/tsc.c and where it does 'set_cputicker(rdtsc, 
> tsc_freq, 1)' change the last parameter to '0' and see if they go away.

OK.

Kris

Received on Wed Feb 22 2006 - 18:32:27 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:52 UTC