Re: [PATCH] kbdmux(4) update

Markus,

[...]

>>>Great work! With this patch I'm currently working since half an hour with
>>>a PS/2 mouse, a Bluetooth mouse, a PS/2 keyboard and a Bluetooth mouse in
>>>parallel without any ill effects. Without it, the machine froze within
>>>seconds.
>>
>>cool, thanks for the report. btw, did you mean "ps/2 keyboard and a
>>bluetooth keyboard" (not mouse) above? or you really have 2 bluetooth
>>mice going at the same time?
> 
> Actually I meant "ps/2 keyboard and a bluetooth keyboard", but I did a little 
> bit of further testing and now have:
> 
>  - one Logitech ps/2 mouse
>  - one Logitech MX1000 bluetooth mouse
>  - two Logitech MX900 bluetooth mice
>  - one Cherry ps/2 keyboard
>  - one Logitech MX5000 bluetooth keyboard
> 
> working in parallel flawlessly :) I would say: Awesome work Maksim!

did you have all these things connected at once? :) if so, then this is 
quite an impressive collections :)

please give yourself a credit too. you picked up where i left with 
bthidd(8), found and fixed silly typos etc. thank you for doing this.

>>>Btw: I'm getting LORs from vkbd(4) when working with the bluetooth
>>>keyboard (6-STABLE from about an hour ago with the kndmux patch):
>>
>>thanks for reporting this. it has nothing to do with the kdbmux(4)
>>patch. it has been there for quite a long time. i will fix it.
> 
> Thanks!

could you please give a try to the following vkbd(4) patch?

http://people.freebsd.org/~emax/vkbd.c.diff.txt

this patch essentially removes custom locking from the vkbd(4) and makes 
it rely on Giant mutex (just like the rest of keyboard drivers and 
syscons(4) do).

thanks,
max