Re: cvs commit: src/sys/dev/em if_em.c if_em.h

Am Mittwoch, 11. Januar 2006 01:30 CEST schrieb Scott Long:
> scottl      2006-01-11 00:30:25 UTC
>
>   FreeBSD src repository
>
>   Modified files:
>     sys/dev/em           if_em.c if_em.h
>   Log:
>   Significant performance improvements for the if_em driver:
>
>   - Only update the rx ring consumer pointer after running through the
> rx loop, not with each iteration through the loop.
>   - If possible, use a fast interupt handler instead of an ithread
> handler.  Use the interrupt handler to check and squelch the interrupt,
> then schedule a taskqueue to do the actual work.  This has three
> benefits:

Thank you very much for your work! Since I'm using many em cards and can't 
get higher tranfer rates compared to fxp (but I wanted to double it so I 
spent some money to replace F-Eth equipment with GbE) I'd like to apply 
your work to RELENG_6. I made the attached diff, but compiler stops here:

/usr/obj/GUNE/usr/src/make.i386/make -V CFILES -V SYSTEM_CFILES -V 
GEN_CFILES |  MKDEP_CPP="cc -E" CC="cc" xargs mkdep -a -f .newdep -O2 
-pipe -fno-strict-aliasing -march=pentium3 -Wall -Wredundant-decls 
-Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith 
-Winline -Wcast-qual  -fformat-extensions -std=c99 -g -nostdinc -I-  -I. 
-I/usr/src/sys -I/usr/src/sys/contrib/altq -I/usr/src/sys/contrib/ipfilter 
-I/usr/src/sys/contrib/pf -I/usr/src/sys/contrib/dev/ath 
-I/usr/src/sys/contrib/dev/ath/freebsd -I/usr/src/sys/contrib/ngatm 
-I/usr/src/sys/dev/twa -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include 
opt_global.h -fno-common -finline-limit=8000 --param 
inline-unit-growth=100 --param large-function-growth=1000  
-mno-align-long-strings -mpreferred-stack-boundary=2  -mno-mmx -mno-3dnow 
-mno-sse -mno-sse2 -ffreestanding
/usr/src/sys/dev/em/if_em.c:3178:34: macro "VLAN_INPUT_TAG" requires 4 
arguments, but only 3 given
mkdep: compile failed
*** Error code 1

Stop in /usr/obj/GUNE/usr/src/sys/CUV-LV.
*** Error code 1

I have no idea how to correct this, could you please help me? Or isn't it 
that simple, eg. VLAN isn't the same level in RELENG_6 and -current?

Thanks in advance,

-Harry

>   Revision  Changes    Path
>   1.98      +193 -18   src/sys/dev/em/if_em.c
>   1.41      +10 -1     src/sys/dev/em/if_em.h
> _______________________________________________
> cvs-src_at_freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/cvs-src
> To unsubscribe, send any mail to "cvs-src-unsubscribe_at_freebsd.org"