Hi, John Baldwin wrote: > I sent this to you on IRC, but for the archives, here's a possible fix. It > looks like vm_object_deallocate() never unlocks Giant if it locks it, and the > leak would only happen if mpsafevfs=0 or you are using a non-safe filesystem: The real problem is that vm_object_deallocate() doesn't expect the object's type to change if it sees it's a vnode, when it's not holding the object lock: /* * In general, the object should be locked when working with * its type. In this case, in order to maintain proper lock * ordering, an exception is possible because a vnode-backed * object never changes its type. */ vfslocked = 0; if (object->type == OBJT_VNODE) { struct vnode *vp = (struct vnode *) object->handle; vfslocked = VFS_LOCK_GIANT(vp->v_mount); } VM_OBJECT_LOCK(object); if (object->type == OBJT_VNODE) { vm_object_vndeallocate(object); VFS_UNLOCK_GIANT(vfslocked); return; } The comment is actually wrong, and the object's type can change to OBJT_DEAD when the corresponing vnode gets freed, so maybe you might want to change it. -- SuleimanReceived on Thu Jan 19 2006 - 00:31:13 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:51 UTC