Re: Please help reviewing ! Got another crash because of the ttymodem() / ttyclose() race

From: John Baldwin <jhb_at_freebsd.org>
Date: Mon, 10 Jul 2006 20:22:12 -0400
On Saturday 08 July 2006 02:44, Martin Blapp wrote:
> >
> > Ok, fixed. Does it look better now ?
> >
> 
> here's the link again.
> 
> http://mx.imp.ch/patches/patch-tty.t_pgrp.diff

You can't lock tp->t_pgrp before you check it for NULL!  Seriously, the
solution is to make sure Giant is held everywhere that t_pgrp is
accessed for now.

-- 
John Baldwin
Received on Mon Jul 10 2006 - 23:15:53 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:58 UTC