On 6/14/06, Wojciech A. Koszek <wkoszek_at_freebsd.org> wrote: > On Wed, Jun 14, 2006 at 01:05:31AM +0000, Wojciech A. Koszek wrote: > > Hello, > > And yes, it's better to set a message subject before sending. I haven't tested your patch yet, but from reading the tgz I can spot at least 2 typos in src/sys/vm/memtrace.c lines 129 and 132: static int memtrace_cache_misses; SYSCTL_INT(_vm_memtrace, OID_AUTO, misses, CTLFLAG_RD, &memtrace_cache_allocs, 0, "Number of misses to the MTrace cache"); static int memtrace_cache_gced; SYSCTL_INT(_vm_memtrace, OID_AUTO, gced, CTLFLAG_RD, &memtrace_cache_allocs, 0, "Number of garbage collected entries"); these should instead be: static int memtrace_cache_misses; SYSCTL_INT(_vm_memtrace, OID_AUTO, misses, CTLFLAG_RD, &memtrace_cache_misses, 0, "Number of misses to the MTrace cache"); static int memtrace_cache_gced; SYSCTL_INT(_vm_memtrace, OID_AUTO, gced, CTLFLAG_RD, &memtrace_cache_gced, 0, "Number of garbage collected entries"); everything else seems fine to me but I've _VERY_ little experience with FreeBSD internals and I'm just exploring it these days. HTH -- Valentino Volonghi aka Dialtone Now running MacOS X 10.4 Blog: http://vvolonghi.blogspot.com Home Page: http://xoomer.virgilio.it/dialtone/Received on Wed Jun 14 2006 - 15:43:09 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:57 UTC