Re: Unable to build acpi_asus module on current today

> From: Jung-uk Kim <jkim_at_FreeBSD.org>
> Date: Thu, 29 Jun 2006 20:59:45 -0400
> 
> On Thursday 29 June 2006 07:30 pm, Kevin Oberman wrote:
> > Today I tried rebuilding my laptop running current. Building the
> > kernel module acpi_asus, the build bombed with the error:
> > ===> acpi_asus (all)
> > cc -O2 -fno-strict-aliasing -pipe -Werror -D_KERNEL -DKLD_MODULE
> > -nostdinc -I-
> > -I/usr/src/sys/modules/acpi/acpi_asus/../../../contrib/dev/acpica
> > -I. -I_at_ -I_at_/contrib/altq -finline-limit=8000 --param
> > inline-unit-growth=100 --param large-function-growth=1000
> > -fno-common  -mno-align-long-strings -mpreferred-stack-boundary=2 
> > -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding
> > -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes 
> > -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef
> > -fformat-extensions -c /usr/src/sys/modules
> > /acpi/acpi_asus/../../../dev/acpi_support/acpi_asus.c
> > /usr/src/sys/modules/acpi/acpi_asus/../../../dev/acpi_support/acpi_
> >asus.c: In function `acpi_asus_attach':
> > /usr/src/sys/modules/acpi/acpi_asus/../../../dev/acpi_support/acpi_
> >asus.c:584: error: 'for' loop initial declaration used outside C99
> > mode
> >
> > But this module has not been touched since April and I have built
> > all of it many times since then. Several other modules seem to have
> > the same problem of declaring a variable in a for statement.
> >
> > I moved the declaration to its own statement before the "for" and
> > it compiles fine.
> >
> > Did some compiler default recently change? I have no compile
> > options on my make.conf.
> 
> Yes:
> 
> http://docs.freebsd.org/cgi/mid.cgi?200606292115.k5TLFQch022605
> 
> A quick fix:
> 
> Index: sys/conf/kmod.mk
> ===================================================================
> RCS file: /home/ncvs/src/sys/conf/kmod.mk,v
> retrieving revision 1.208
> diff -u -r1.208 kmod.mk
> --- sys/conf/kmod.mk     27 May 2006 16:32:05 -0000      1.208
> +++ sys/conf/kmod.mk     30 Jun 2006 00:57:37 -0000
> _at__at_ -85,8 +85,10 _at__at_
>  .if ${CC} == "icc"
>  NOSTDINC=      -X
>  .else
> +C_DIALECT=     -std=c99
>  NOSTDINC=      -nostdinc
>  .endif
> +CFLAGS+=       ${C_DIALECT}
>  CFLAGS:=       ${CFLAGS:N-I*} ${NOSTDINC} -I- ${INCLMAGIC} ${CFLAGS:M-I*}
>  .if defined(KERNBUILDDIR)
>  CFLAGS+=       -DHAVE_KERNEL_OPTION_HEADERS -include ${KERNBUILDDIR}/opt_global.h

Jung-uk,

Thanks you so much. I might have found this, but it would have taken a
long time!

Looks like this needs to be fixed in the base system or all of the
modules need to be checked and fixed to compile with the new flags.
-- 
R. Kevin Oberman, Network Engineer
Energy Sciences Network (ESnet)
Ernest O. Lawrence Berkeley National Laboratory (Berkeley Lab)
E-mail: oberman_at_es.net			Phone: +1 510 486-8634