Re: When will bsnmp stop breaking -current builds

On Wed, Mar 08, 2006 at 11:55:39AM -0700, M. Warner Losh wrote:
> In message: <20060308152413.GA43764_at_flame.pc>
>             Giorgos Keramidas <keramida_at_ceid.upatras.gr> writes:
> : On 2006-03-08 14:53, Dag-Erling Sm?rgrav <des_at_des.no> wrote:
> : > Harti Brandt <hartmut.brandt_at_dlr.de> writes:
> : > > You seem to be the only one having this problem, so this looks like
> : > > a problem on your side.
> : >
> : > Far from it.  I had the same problem, and solved it by adding a
> : > NO_BSNMP knob (see attached patch).
> : >
> : > The deeper problem is that gensnmptree is a build tool, but isn't
> : > treated as such by the build system, so cross-builds and source
> : > updates from older versions are broken.
> : 
> : I solved the original gensnmptree problems I had when I moved back and
> : forth around January 25-26th builds, with:
> : 
> : %%%
> : Index: Makefile.inc1
> : ===================================================================
> : --- Makefile.inc1       (revision 19)
> : +++ Makefile.inc1       (working copy)
> : _at__at_ -839,6 +839,7 _at__at_
> :      usr.bin/rpcgen \
> :      usr.bin/xinstall \
> :      usr.sbin/config \
> : +    usr.sbin/bsnmpd/gensnmptree \
> :      ${_crunchgen} \
> :      ${_pwd_mkdb}
> :         ${_+_}_at_${ECHODIR} "===> ${_tool} (obj,depend,all,install)"; \
> : %%%
> : 
> : Things worked fine after this :)
> 
> This seems like a reasonable thing to do for now, since it is clear
> that regardless of theory, gensnmptree in practice is a buildtool.
> 
Please make it a ${_gensnmptree} and define it only for vulnerable
versions.  If __FreeBSD_version wasn't bumped after it's been fixed,
put the next __FreeBSD_version value so that it stops rebuilding it
when the version gets bumped.


Cheers,
-- 
Ruslan Ermilov
ru_at_FreeBSD.org
FreeBSD committer