Re: CFT: new ath hal (take 2)

Sam Leffler wrote:
> Eric Anderson wrote:
>> Sam Leffler wrote:
>>> A new test snapshot is available at:
>>>
>>> http://people.freebsd.org/~sam/ath_hal-20060506.tgz
>>>
>>> This is 0.9.17.0 and is known to work on sparc (tested) and may well 
>>> work on alpha (untested but likely the same issue that broke sparc).
>>>
>>> This code should be a drop-in replacement for what's in cvs in HEAD 
>>> but be sure to rebuild both the driver and rate control module as 
>>> there are ABI changes.  Note that to use this hal with RELENG_6 or 
>>> other branches other than HEAD you must have rev 1.143 of if_ath.c.  
>>> To build a sparc module you must have rev 1.5 of 
>>> modules/ath_hal/Makefile and rev 1.539 of conf/options.
>>>
>>> Please test and report regressions.
>>
>> On 6.1-RC2, I get compile errors:
>>  6.1-RC FreeBSD 6.1-RC #15: Fri May  5 08:29:44 CDT 2006
>> if_ath.c: __FBSDID("$FreeBSD: src/sys/dev/ath/if_ath.c,v 1.94.2.18 
>> 2006/05/02 17:06:35 sam Exp $");
>>
>> [..snip..]
>> ===> ath (all)
>> cc -O2 -pipe -march=pentiumpro -fno-strict-aliasing -Werror -D_KERNEL 
>> -DKLD_MODULE -nostdinc -I-  -I. 
>> -I/usr/src/sys/modules/ath/../../contrib/dev/ath/freebsd 
>> -I/usr/src/sys/modules/ath/../../contrib/dev/ath 
>> -DHAVE_KERNEL_OPTION_HEADERS -include 
>> /usr/obj/usr/src/sys/NEUTRINO/opt_global.h -I. -I_at_ -I_at_/contrib/altq 
>> -I_at_/../include -finline-limit=8000 -fno-common -g 
>> -I/usr/obj/usr/src/sys/NEUTRINO -mno-align-long-strings 
>> -mpreferred-stack-boundary=2  -mno-mmx -mno-3dnow -mno-sse -mno-sse2 
>> -ffreestanding -Wall -Wredundant-decls -Wnested-externs 
>> -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline 
>> -Wcast-qual  -fformat-extensions -std=c99 -c 
>> /usr/src/sys/modules/ath/../../dev/ath/if_ath.c
>> /usr/src/sys/modules/ath/../../dev/ath/if_ath.c: In function 
>> `ath_attach':
>> /usr/src/sys/modules/ath/../../dev/ath/if_ath.c:296: warning: passing 
>> arg 3 of `ath_hal_attach' makes pointer from integer without a cast
>> /usr/src/sys/modules/ath/../../dev/ath/if_ath.c:296: warning: passing 
>> arg 4 of `ath_hal_attach' makes pointer from integer without a cast
>> *** Error code 1
>>
>> Stop in /usr/src/sys/modules/ath.
>> *** Error code 1
>>
>> Stop in /usr/src/sys/modules.
>> *** Error code 1
>>
>> Stop in /usr/obj/usr/src/sys/NEUTRINO.
>> *** Error code 1
>>
>> Stop in /usr/src.
>> *** Error code 1
>>
>> Stop in /usr/src.
>>
>>
>>
>>
>>
> 
> Like I said:
> 
> Note that to use this hal with RELENG_6 or
>  >> other branches other than HEAD you must have rev 1.143 of if_ath.c.

*sigh* - my brain converted 1.94 to 1.194.. Sorry for the noise, and 
thanks for smacking me around.. :)


Eric



-- 
------------------------------------------------------------------------
Eric Anderson        Sr. Systems Administrator        Centaur Technology
Anything that works is better than anything that doesn't.
------------------------------------------------------------------------