Re: Support for ICH7 controller in PowerBook Pro

Gavin Atkinson wrote:
> On Sun, 2006-05-14 at 23:24 -0700, Maxim Sobolev wrote:
>> Søren Schmidt wrote:
>>> On Tir, 2006-04-25 at 01:03 -0700, Maxim Sobolev wrote:
>>>> Hi Søren,
>>>>
>>>> Attached please find small patch which adds support for 82801GBM/GHM 
>>>> SATA controller found in intel-based Macs, particularly in MacBook Pro.
>>>>
>>>> Please review & approve.
>>> I'll look into it, I think Intel has a few other new chips I should add
>>> in the same go, give me a few days...
>> Any progress with this? Few days have turned into few weeks, and I don't 
>> want them turn into few months. :)
> 
> Be aware that I believe your patch is slightly wrong.  As far as I can
> tell the chip ID you've added is the non-AHCI version.  I have the same
> chip in my new Toshiba laptop, and submitted a more complete PR
> (kern/97228) over the weekend.

MacBook doesn't work with your patch - FreeBSD detects controller but 
doesn't see any disks attached to it. :( Putting AHCI back solves the 
problem.

I wonder if Intel has shipped two different controllers with the same 
pci ids.

Just in the case, attached is appropriate entry from pciconf -lv output:

atapci1_at_pci0:31:2:      class=0x01018f card=0x72708086 chip=0x27c48086 
rev=0x02 hdr=0x00
     vendor   = 'Intel Corporation'
     device   = '82801GBM/GHM (ICH7-M Family) Serial ATA Storage Controller'
     class    = mass storage
     subclass = ATA

And dmesg:

atapci1: <Intel ICH7 SATA300 controller> port 
0x40d8-0x40df,0x40f4-0x40f7,0x40d0-0x40d7,0x40f0-0x40f3,0x4020-0x402f 
mem 0x98405000-0x984053ff irq 19 at device 31.2 on pci0
ata2: <ATA channel 0> on atapci1
ata3: <ATA channel 1> on atapci1
ad5: 95396MB <Seagate ST910021AS 3.07> at ata2-slave SATA150

-Maxim