Re: FreeBSD-SA-06:14.fpu

On Friday 19 May 2006 07:37, Rostislav Krasny wrote:
> On Sun, 30 Apr 2006 16:19:29 -0700
>
> Colin Percival <cperciva_at_freebsd.org> wrote:
> > Rostislav Krasny wrote:
> > > Other possible solution is making the fpu_clean_state() optional by
> > > something like following:
> > >
> > > #ifdef BUG_FXSAVE
> > > #define fpu_clean_state() __fpu_clean_state()
> > > #else
> > > #define fpu_clean_state() ;
> > > #endif
> > >
> > > ... and including "options BUG_FXSAVE" to GENERIC.
> >
> > Yes, this is probably the right solution.  My priority was to fix the
> > bug; optimizing performance comes second.
>
> Ok. Is this solution going to be done some day? I could try to make a
> patch but I'm not familiar with the build infrastructure internals.
>
> P.S. what is a better option name: "options BUG_FXSAVE" or "options
> AMD_FXSAVE"?

Patch is welcome, but I would call it BUG_FXSAVE like Linux's select()
changed timeout value which only added incompatibility rather than
advantage.

David Xu