Re: small patch for ngctl

Harti Brandt wrote:
> Hi,
>
> On Fri, 19 May 2006, Ganbold wrote:
>
> I did not yet look at your patch, but does it work with ngctl receiving 
> unexpected messages? 
How can I test this? I tested on RELENG_6 machine which has following hooks:

ngctl mkpeer xl1: tee lower right
ngctl connect xl1: xl1:lower upper left
ngctl name xl1:lower xl1_tee
ngctl mkpeer xl1_tee: netflow left2right iface0
ngctl name xl1:lower.left2right netflow
ngctl connect xl1_tee: netflow: right2left iface1
ngctl msg netflow: setifindex { iface=0 index=2 }
ngctl msg netflow: setifindex { iface=1 index=1 }
ngctl mkpeer netflow: ksocket export inet/dgram/udp
ngctl msg netflow:export connect inet/127.0.0.1:8818

ngctl mkpeer xl0: tee lower right
ngctl connect xl0: xl0:lower upper left
ngctl name xl0:lower xl0_tee
ngctl mkpeer xl0_tee: netflow left2right iface2
ngctl name xl0:lower.left2right netflow0
ngctl msg netflow0: setifindex { iface=2 index=4 }
ngctl connect xl0_tee: netflow0: right2left iface3
ngctl msg netflow0: setifindex { iface=3 index=3 }
ngctl mkpeer netflow0: ksocket export inet/dgram/udp
ngctl msg netflow0:export connect inet/127.0.0.1:8818

It seems like works at a first glance.
> I remember we had something like this in the tree 
> already, but it was backed out, because readline (or libedit, don't 
> remember which one) waiting for input blocked receiving control messages, 
> as far as I remember.
>   
I see. How can I make system to send unexpected messages to ngctl?

Ganbold
> harti
>
> G>I've made a small patch enhancement for ngctl to support commands history via
> G>up/down keys when ngctl works under interactive mode.
> G>It was tested on 7.0-CURRENT machine (FreeBSD 7.0-CURRENT #3: Tue May 16
> G>19:17:48 ULAST 2006).
> G>
> G>I thought this feature might be useful for all. I hope my patch follows
> G>style(9) and it is made against CURRENT, it should also cleanly apply on
> G>RELENG_6.
> G>
> G>I saw a similar enhancement patch in PR
> G>http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/87352 which adds line edit and
> G>history support to ngctl(8) via libedit.
> G>
> G>My patch uses TERMIOS(4) structure which I thought more portable. Maybe I'm
> G>wrong.
> G>
> G>Please let me know if there is anything that I did wrong.
> G>
> G>thanks,
> G>
> G>Ganbold
> G>
> G>
> G>
>
>
>
>