Re: small patch for ngctl

Harti Brandt wrote:
> On Fri, 19 May 2006, Ganbold wrote:
>
> G>Gleb Smirnoff wrote:
> G>> On Fri, May 19, 2006 at 05:04:25PM +0900, Ganbold wrote:
> G>> G> I see. How can I make system to send unexpected messages to ngctl?
> G>> 
> G>>   
> G>> > kldload ng_ether
> G>> > ngctl
> G>> >     
> G>> 
> G>> + ls
> G>> There are 2 total nodes:
> G>>   Name: ngctl990        Type: socket          ID: 00000004   Num hooks: 0
> G>>   Name: fxp0            Type: ether           ID: 00000002   Num hooks: 0
> G>> + connect fxp0: qqq lower
> G>> + Rec'd data packet on hook "qqq":
> G>> 0000:  00 10 a4 89 56 3f 00 30 48 80 34 83 08 00 45 00  ....V?.0H.4...E.
> G>> 0010:  05 dc a0 91 20 00 40 11 91 7a 51 13 40 70 51 13  .... ._at_..zQ._at_pQ.
> G>> 0020:  40 6f 08 01 03 27 20 88 9b c6 77 90 1f ee 00 00  _at_o...' ...w.....
> G>> 0030:  00 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
> G>> 0040:  00 00 00 00 00 00 00 00 00 01 00 00 00 01 00 00  ................
> G>> 0050:  01 a4 00 00 00 01 00 00 03 e8 00 00 00 00 00 00  ................
> G>> 
> G>>   
> G>It receives bunch of stuffs with patched ngctl:
> G>
> G>+ ls
> G>There are 3 total nodes:
> G> Name: ngctl3919       Type: socket          ID: 00000005   Num hooks: 1
> G> Name: fxp0            Type: ether           ID: 00000003   Num hooks: 1
> G> Name: re0             Type: ether           ID: 00000002   Num hooks: 0
> G>+ connect re0: qqq lower
> G>ngctl: send msg: File exists
> G>+ connect re0: qqqq lower
> G>+
> G>Rec'd data packet on hook "qqqq":
> G>0000:  ff ff ff ff ff ff 00 14 6c 2e 23 71 08 00 45 00  ........l.#q..E.
> G>0010:  00 4e 17 32 00 00 80 11 a0 e2 c0 a8 00 3b c0 a8  .N.2.........;..
> G>0020:  00 ff 00 89 00 89 00 3a 9b d7 80 8d 01 10 00 01  .......:........
> G>0030:  00 00 00 00 00 00 20 45 43 45 42 46 45 45 45 46  ...... ECEBFEEEF
> G>0040:  46 45 4d 45 42 45 4e 43 41 43 41 43 41 43 41 43  FEMEBENCACACACAC
> G>0050:  41 43 41 43 41 43 41 00 00 20 00 01              ACACACA.. ..
> G>Rec'd data packet on hook "qqqq":
> G>0000:  ff ff ff ff ff ff 00 14 6c 2e 28 9d 08 06 00 01  ........l.(.....
> G>0010:  08 00 06 04 00 01 00 14 6c 2e 28 9d c0 a8 00 07  ........l.(.....
> G>0020:  00 00 00 00 00 00 c0 a8 00 3b 00 00 00 00 00 00  .........;......
> G>0030:  00 00 00 00 00 00 00 00 00 00 00 00              ............
> G>+
> G>Rec'd data packet on hook "qqqq":
> G>0000:  ff ff ff ff ff ff 00 14 6c 2e 23 71 08 00 45 00  ........l.#q..E.
> G>0010:  00 4e 17 47 00 00 80 11 a0 cd c0 a8 00 3b c0 a8  .N.G.........;..
> G>0020:  00 ff 00 89 00 89 00 3a 9b d8 80 8e 01 10 00 01  .......:........
> G>0030:  00 00 00 00 00 00 20 45 43 45 42 46 45 45 45 46  ...... ECEBFEEEF
> G>0040:  46 45 4d 45 42 45 4e 43 41 43 41 43 41 43 41 43  FEMEBENCACACACAC
> G>0050:  41 43 41 43 41 41 41 00 00 20 00 01              ACACAAA.. ..
> G>+
> G>Rec'd data packet on hook "qqqq":
> G>0000:  ff ff ff ff ff ff 00 14 6c 2e 23 71 08 00 45 00  ........l.#q..E.
> G>0010:  00 4e 17 4e 00 00 80 11 a0 c6 c0 a8 00 3b c0 a8  .N.N.........;..
> G>0020:  00 ff 00 89 00 89 00 3a b1 dc 80 8f 01 10 00 01  .......:........
> G>0030:  00 00 00 00 00 00 20 45 4f 45 42 46 44 45 42 45  ...... EOEBFDEBE
> G>0040:  42 43 41 43 41 43 41 43 41 43 41 43 41 43 41 43  BCACACACACACACAC
> G>...
> G>
> G>Is it what it supposed to handle?
>
> Yes. Nice. That's a feature I was missing for a long time.
>   
Did you test this patch by any chance? Is there any issue with it to be 
not committed?
Please let me know.

thanks,

Ganbold

> harti
> _______________________________________________
> freebsd-current_at_freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org"
>
>
>
>