Re: [head tinderbox] failure on sparc64/sun4v

From: John Birrell <jb_at_what-creek.com>
Date: Sat, 4 Nov 2006 07:00:47 +0000
On Sat, Nov 04, 2006 at 01:04:21AM -0500, FreeBSD Tinderbox wrote:
> [...]
> /src/sys/netinet/sctp_pcb.c:3394: warning: previous implicit declaration of 'atomic_add_16' was here
> /src/sys/netinet/sctp_pcb.c:3470: warning: nested extern declaration of `atomic_add_16'
> /src/sys/netinet/sctp_pcb.c:3394: warning: redundant redeclaration of 'atomic_add_16'
> /src/sys/netinet/sctp_pcb.c:3394: warning: previous implicit declaration of 'atomic_add_16' was here
> /src/sys/netinet/sctp_pcb.c: In function `sctp_load_addresses_from_init':
> /src/sys/netinet/sctp_pcb.c:4382: warning: nested extern declaration of `atomic_add_16'
> /src/sys/netinet/sctp_pcb.c:3394: warning: redundant redeclaration of 'atomic_add_16'
> /src/sys/netinet/sctp_pcb.c:3394: warning: previous implicit declaration of 'atomic_add_16' was here
> *** Error code 1

This is a problem on sparc64 and sun4v because we don't have an atomic_add_16.

I looked at the code in Solaris to see what asm is required to implement
it and it takes 22 statements compared to 2 for a 64 bit variable and 4 for
a 32 bit variable.

Can't the code be changed to use a more typical variable size of the
arches we have? 32 bits would be a better choice.

--
John Birrell
Received on Sat Nov 04 2006 - 05:59:23 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:02 UTC