Re: ZFS patches for FreeBSD.

Pawel Jakub Dawidek wrote:
> This is a first set of patches, which allows to use ZFS file system from
> OpenSolaris on FreeBSD.

Thanks for your much appreciated work!

> To apply the patch you need the following steps:
> 
> 	# cd /usr/src
> 	# mkdir -p cddl/lib/lib{avl,nvpair,umem,uutil,zfs,zpool}
> 	# mkdir -p cddl/usr.bin/ztest
> 	# mkdir -p cddl/usr.sbin/{zdb,zfs,zpool}
> 	# mkdir -p compat/opensolaris/{include,misc}
> 	# mkdir -p contrib/opensolaris/cmd/{zdb,zfs,zpool,ztest}
> 	# mkdir -p contrib/opensolaris/common/{acl,avl,nvpair,zfs}
> 	# mkdir -p contrib/opensolaris/head
> 	# mkdir -p contrib/opensolaris/lib/libnvpair
> 	# mkdir -p contrib/opensolaris/lib/lib{uutil,zfs}/common
> 	# mkdir -p contrib/opensolaris/lib/libzpool/common/sys
> 	# mkdir -p sys/compat/opensolaris/{kern,machine,rpc,sys}
> 	# mkdir -p sys/contrib/opensolaris/uts/common/fs/zfs/sys
> 	# mkdir -p sys/contrib/opensolaris/uts/common/{os,rpc}
> 	# mkdir -p sys/contrib/opensolaris/uts/common/sys/fm/fs
> 	# mkdir -p sys/contrib/opensolaris/uts/common/sys/fs
> 	# mkdir -p sys/modules/zfs
> 	# fetch http://people.freebsd.org/~pjd/patches/zfs_20061117.patch.bz2
> 	# bzip2 -d zfs_20061117.patch.bz2
> 	# patch < zfs_20061117.patch

Is it not simpler/enough to replace all these commands with:

# cd /usr/src
# fetch http://people.freebsd.org/~pjd/patches/zfs_20061117.patch.bz2
# bzip2 -d zfs_20061117.patch.bz2
# patch -p0 < zfs_20061117.patch

or even shorter:

# cd /usr/src
# fetch -o - \
  http://people.freebsd.org/~pjd/patches/zfs_20061117.patch.bz2 \
  | bunzip2 | patch -p0

?

The point is that using the '-p0' option we can avoid creating
directories manually.

--
Alex Dupre