Re: Much improved sendfile(2) kernel implementation

From: David Malone <dwmalone_at_maths.tcd.ie>
Date: Sat, 23 Sep 2006 15:28:36 +0100
> The congestion window is increased based on the ACK's received.  TSO
> is only done on the send side and only up to the current congestion
> window.  I have been careful not to get any changes in congestion
> control behavior with TSO.  (Which does not mean that there may be
> other bugs lurking in our congestion control.)

I think the reason this happened in Linux was because thw congestion
window is counted in segments, which were now TSO sized. You'd send
1 TSO sized segment, get back (say) 10 ACKs because of segmentation
and increase the window size by 10*TSO_SEG_SIZE/cwnd insead of
10*REAL_MSS/cwnd. We're unlikely to have exactly the same bug,
because we count cwnd in bytes, but it doesn't rule out haveing
other unexpected/subtle interactions (like higher varience of RTT
esitmation - I guess all packets in a TSO segment are now sent with
the same timestamp?).

	David.
Received on Sat Sep 23 2006 - 12:28:44 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:00 UTC