Re: "recursive lock for object" & "unlocking unheld lock" in smb

On Wednesday 27 September 2006 10:01, Alexander Leidinger wrote:
> Hi,
> 
> yesterday I rsynced a smb share from a samba-3.0.x server (FreeBSD 4)  
> via a smb mount (current from Sep 23) "locally" (mount -t smbfs from  
> the samba server and rsync a/ b/; most easy solution to convert some  
> ISO-8859-1 filenames to UTF-8 ("dos charset = UTF8" in smb.conf!)  
> while moving to another system).
> 
> Today I noticed the following in the daily mail on the -current system:

If you are willing to panic your box, can you try the patch below and get a 
crashdump when it panics?  Then, send me the stack trace from the panic (and 
keep the crashdump around).  Thanks.

Index: smb_conn.c
===================================================================
RCS file: /usr/cvs/src/sys/netsmb/smb_conn.c,v
retrieving revision 1.17
diff -u -r1.17 smb_conn.c
--- smb_conn.c	17 Jul 2006 16:12:59 -0000	1.17
+++ smb_conn.c	27 Sep 2006 15:42:35 -0000
_at__at_ -350,6 +350,7 _at__at_
 	if (smb_co_lockstatus(cp, td) == LK_EXCLUSIVE && 
 	    (flags & LK_CANRECURSE) == 0) {
 		SMBERROR("recursive lock for object %d\n", cp->co_level);
+		panic("rescursive lock for object %p", cp);
 		return 0;
 	}
 	return lockmgr(&cp->co_lock, flags, &cp->co_interlock, td);


-- 
John Baldwin