Re: lockf in installworld -- not a good idea

From: Pawel Jakub Dawidek <pjd_at_FreeBSD.org>
Date: Fri, 29 Sep 2006 17:55:26 +0200
On Fri, Sep 29, 2006 at 02:20:06PM +0100, Robert Watson wrote:
> I've noticed an increasing intolerance in our tools for system install and maintenance to locking not being implemented over the past few years.  I no longer get working 
> cron on boxes with neither rpc.lockd nor local locking enabled, for
> example. [...]

If you are refering to my change in which cron(8) started to use
pidfile(3), then I'm sorry, but you're wrong.

cron(8) from the very beginning was exiting when it had problems with
creating a pidfile, please check function acquire_daemonlock() in:

	http://www.freebsd.org/cgi/cvsweb.cgi/src/usr.sbin/cron/lib/misc.c?rev=1.1&content-type=text/x-cvsweb-markup

My pidfile(3) commit is here:

	http://lists.freebsd.org/pipermail/cvs-all/2005-August/132374.html

Where I try to explain cron(8)'s behaviour.

The way I prefer is to ignore errors other than EEXIST - you can check
EXAMPLES section in the pidfile(3) manual page for more info. I just
didn't wanted to change cron(8)'s original behaviour.

I do agree, that this shouldn't be treated as critical error and I can
change it if you like.

-- 
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd_at_FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!

Received on Fri Sep 29 2006 - 13:56:08 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:00 UTC