Re: zdb patch

On Sat, Apr 14, 2007 at 11:01:35PM +0900, Hidetoshi Shimokawa wrote:
> On 4/14/07, Pawel Jakub Dawidek <pjd_at_freebsd.org> wrote:
> >On Sat, Apr 14, 2007 at 10:31:19PM +0900, Hidetoshi Shimokawa wrote:
> >> Here is a patch for zdb.
> >> Now we can 'zdb -u pool' :-)
> >>
> >> ==== //depot/user/simokawa/firewire/contrib/opensolaris/lib/libzpool/common/kernel.c#2 - /home/p4/firewire/contrib/opensolaris/lib/libzpool/common/kernel.c ====
> >> _at__at_ -38,6 +38,7 _at__at_
> >>  #include <sys/zfs_context.h>
> >>  #include <sys/zmod.h>
> >>  #include <sys/utsname.h>
> >> +#include <sys/disk.h>
> >>
> >>  /*
> >>   * Emulation of kernel services in userland.
> >> _at__at_ -291,7 +292,11 _at__at_
> >>
> >>       ASSERT(abstime > 0);
> >>  top:
> >> +#if 0
> >>       delta = abstime - lbolt;
> >> +#else /* for compatibility with FreeBSD kernel */
> >> +     delta = abstime;
> >> +#endif
> >
> >What is this change for? It works ok without it here.
> 
> It is necessary for userland because of your change 104486.
> (see p4 describe 104486)
> 
> Without above patch, cv_timedwait() never sleeps and arc_reclaim_thread
> never releases the lock.

Right... How can I reproduce the problem, because ztest seems to work
just fine?

BTW. Please commit this change as well, but just remove ' - lbolt' and
forget about this '#if 0'.

-- 
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd_at_FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!