Re: off-by-one error in sbin/atm

From: Roman Divacky <rdivacky_at_freebsd.org> Date: Sat, 14 Apr 2007 18:31:46 +0200 · This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:08 UTC

On Sat, Apr 14, 2007 at 08:09:40PM +0400, Maxim Konovalov wrote:
> On Sat, 14 Apr 2007, 17:42+0200, Roman Divacky wrote:
> 
> > hi
> >
> > in /usr/src/sbin/atm/atmconfig/diag.c on line 871 there's
> > off-by-one error. array of size IFNAMSIZ is being written
> > on IFNAMSIZ, ie. one byte after the array.
> >
> > this code
> >         ifr.ifr_name[IFNAMSIZ] = '\0';
> > should be
> >         ifr.ifr_name[IFNAMSIZ-1] = '\0';
> >
> > thnx for fixing it :)
> 
> fixed, thanks.

thnx, that was fast :) just a note.. this was found by compiling
world using gcc43. I wonder how many more I'll find :)