Re: [RFC, PATCH] Getting rid of direct calls to keyboard's methods via kbdsw[] array

From: Wojciech A. Koszek <wkoszek_at_FreeBSD.ORG>
Date: Sat, 22 Dec 2007 22:19:52 +0000
On Sat, Dec 22, 2007 at 10:56:45AM -0800, Marcel Moolenaar wrote:
> 
> On Dec 21, 2007, at 8:01 PM, Wojciech A. Koszek wrote:
> 
> >My proposal is to unify a way in which we call such specialized
> >methods, so that instead of direct array indexing used to call  
> >specific
> >keyboard method:
> >
> >	(*kbdsw[(kbd)->kb_index]->enable)((kbd))
> >
> >We would use unified interface:
> >
> >	kbdd_enable(kbd)
> >
> >Proposed patch is here:
> >
> >	http://people.freebsd.org/~wkoszek/patches/tty/kbdcleanup.patch
> >
> >Suggestions are welcome.
> 
> I like it. It would be nice to be able to get rid of the 2nd 'd'
> in the kbdd_ prefix though...

Thanks.

I didn't go to kbd_* because I wanted to know if function is strictly
kbd.c-related or is rather indirect call throught keyboard
dispatcher; and do it just by seeing function's name.

-- 
Wojciech A. Koszek
wkoszek_at_FreeBSD.org
http://FreeBSD.czest.pl/dunstan/
Received on Sat Dec 22 2007 - 20:30:32 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:24 UTC