D_NEEDGIANT usage in {amd64,i386}/isa/clock.c

From: Ed Schouten <ed_at_fxq.nl>
Date: Tue, 10 Jul 2007 18:56:06 +0200
Hello,

I was just taking a look at the /dev/nvram code in the isa/clock.c files
of the amd64 and i386 architectures. For some reason, the "nvram" device
needs D_NEEDGIANT. If I take a look at the nvram_open(), nvram_read()
and nvram_write() routines, I see no reason why it should be marked
D_NEEDGIANT.

Both the nvram_read() and nvram_write() routines both perform some
simple bounds checking and then call rtcin() and writertc(). Both of
those routines are already protected from concurrent access through the
RTC_LOCK and RTC_UNLOCK macro's.

Yours,
-- 
 Ed Schouten <ed_at_fxq.nl>
 WWW: http://g-rave.nl/

Received on Tue Jul 10 2007 - 14:56:12 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:14 UTC