Re: cvs commit: src/sys/kern sched_ule.c (fwd)

On Thu, 19 Jul 2007, Yuri Pankov wrote:

> On Tue, Jul 17, 2007 at 06:31:37PM -0700, Jeff Roberson wrote:
>> Thanks everyone for your help.  In summary it sounds like there are two
>> issues.
>>
>> 1)  kqemu explicitly uses sched_lock.  I'll see if I can contact the author
>> about fixing this.
>>
>> 2)  As much as a 6-7% slowdown on buildworld on dual core machines as
>> compared to 4BSD.  I'm not sure if I'm going to do anything about this.
>> Once you get to 4 or 8 cores and -j8 or more they even out with ULE having
>> significantly less system time.  I don't know if I want to compromise that
>> for slightly better dual core compile times.
>>
>> This is in the tree for 7.0 now though.  I'm very excited to see this
>> happen.
>>
>> Thanks again,
>> Jeff
>
> Hi Jeff,
>
> I can't build kernel after this commit, sources updated at Jul, 19, 8am
> GMT, amd64:

Left a file out of an earlier commit.  Sorry!  You can delete those 
asserts or cvsup again.

Thanks,
Jeff

>
> cc -c -O2 -frename-registers -pipe -fno-strict-aliasing  -std=c99 -g
> -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes
> -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef
> -Wno-pointer-sign -fformat-extensions -nostdinc  -I. -I/usr/src/sys
> -I/usr/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS
> -include opt_global.h -fno-common -finline-limit=8000 --param
> inline-unit-growth=100 --param large-function-growth=1000
> -fno-omit-frame-pointer -mcmodel=kernel -mno-red-zone  -mfpmath=387
> -mno-sse -mno-sse2 -mno-mmx -mno-3dnow  -msoft-float
> -fno-asynchronous-unwind-tables -ffreestanding -Werror
> /usr/src/sys/kern/sched_ule.c
> In file included from /usr/src/sys/kern/sched_ule.c:2554:
> /usr/src/sys/kern/kern_switch.c: In function 'maybe_preempt':
> /usr/src/sys/kern/kern_switch.c:270: error: 'sched_lock' undeclared
> (first use in this function)
> /usr/src/sys/kern/kern_switch.c:270: error: (Each undeclared identifier
> is reported only once
> /usr/src/sys/kern/kern_switch.c:270: error: for each function it appears
> in.)
> *** Error code 1
>
> config:
> include         GENERIC
> ident           DARKLIGHT
>
> nooptions       SCHED_4BSD
> options         SCHED_ULE
>
> options         SHMMAXPGS=65536
> options         SEMMNI=40
> options         SEMMNS=240
> options         SEMUME=40
> options         SEMMNU=120
>
> options         GEOM_JOURNAL
>
> device          sound
> device          snd_ich
>
>
> TIA and sorry if this is pilot error,
> Yuri
>