Re: ichwd for ICH8

Mike Tancsa <mike_at_sentex.net> writes:
> Thanks!  On RELENG_6,

The patch is for CURRENT.

> /usr/src/sys/modules/ichwd/../../dev/ichwd/ichwd.c: In function ichwd_clear_noreboot':
> /usr/src/sys/modules/ichwd/../../dev/ichwd/ichwd.c:228: warning: implicit declaration of function `device__printf'
> /usr/src/sys/modules/ichwd/../../dev/ichwd/ichwd.c:228: warning: nested extern declaration of `device__printf'
> *** Error code 1

Typo...

> ichwd module loaded
> ichwd0: <Intel ICH7 watchdog timer> on isa0
> ichwd0: unable to reserve GCS registers
> device_attach: ichwd0 attach returned 6

in ichwd_identify(), the ICH version test is wrong, it should be

-       if (id_p->version == 2) {
+	if (id_p->version >= 6) {

> Same error on current
>
> ichwd module loaded
> ichwd0: <Intel ICH7 watchdog timer> on isa0
> ichwd0: ICH WDT present but disabled in BIOS or hardware
> device_attach: ichwd0 attach returned 6

Not the same error, but probably caused by the same mistake in
ichwd_identify()

DES
-- 
Dag-Erling Smørgrav - des_at_des.no