Re: patch: acpi usermode suspend API change

Lars Engels wrote:
> On Thu, Jun 21, 2007 at 09:26:46AM -0700, Nate Lawson wrote:
>> Lars Engels wrote:
>>> Nate, 
>>>
>>> thanks for your patch. 
>>> But after applying it on a recent -Current I get a lot of kernel messages
>>> like these:
>>> Jun 21 17:48:27 maggie kernel: apm34 opened clone 0xc457fd00
>>> Jun 21 17:48:27 maggie kernel: apm34 closed clone 0xc457fd00
>>> Jun 21 17:48:32 maggie kernel: apm35 opened clone 0xc457ee40
>>> Jun 21 17:48:32 maggie kernel: apm35 closed clone 0xc457ee40
>>> Jun 21 17:48:37 maggie kernel: apm36 opened clone 0xc457ec40
>>> Jun 21 17:48:37 maggie kernel: apm36 closed clone 0xc457ec40
>>> Jun 21 17:48:42 maggie kernel: apm37 opened clone 0xc457fc40
>>> Jun 21 17:48:42 maggie kernel: apm37 closed clone 0xc457fc40
>>> Jun 21 17:48:47 maggie kernel: apm38 opened clone 0xc433b6c0
>>> Jun 21 17:48:47 maggie kernel: apm38 closed clone 0xc433b6c0
>>> Jun 21 17:48:52 maggie kernel: apm39 opened clone 0xc433b240
>> Thanks for testing! Those were there to assist in debugging if people
>> had any problems.
>>
>>> Additionally, pressing the power button only generates this:
>>> Jun 21 17:50:03 maggie kernel: acpi: request to enter state S5 failed
>>>
>>> I need to run 'shutdown -p ' to power the system down.
>> This was already fixed in the updated patch that I plan to commit today.
>>  It's attached or you can just wait for the commit to get it.
> 
> Okay, I cannot test this today, so I will take your committed version
> tomorrow.

Patch has been committed, along with an addition to use a taskq to clean
up the extra devices.  You should find that all this works fine and
/dev/apm is cleaned up.

To upgrade, you should install the /etc/ scripts, acpiconf, and the acpi
kernel module.  Installworld/mergemaster take care of this.  Old
binaries of acpiconf will continue to work fine with just a message
printed once on console that the old API is deprecated.

-- 
Nate