Re: recent USB changes break building of atausb module

On Saturday 23 June 2007 22:54, Pascal Hofstee wrote:
> Hi,
>
> I just updated to a fresh current today to notice that with the recent
> slew of commits to the usb subsystem, the atausb module no longer
> compiles.

I think this is because Warner Losh is doing some cleanup in the old USB 
stack.

--HPS

>
> cc -O2 -fno-strict-aliasing -pipe -march=athlon-mp  -D_KERNEL
> -DKLD_MODULE -std=c99 -nostdinc   -I. -I_at_ -I_at_/contrib/altq
> -finline-limit=8000 --param inline-unit-growth=100 --param
> large-function-growth=1000 -fno-common  -mno-align-long-strings
> -mpreferred-stack-boundary=2  -mno-mmx -mno-3dnow -mno-sse -mno-sse2
> -mno-sse3 -ffreestanding -Wall -Wredundant-decls -Wnested-externs
> -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline
> -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions
> -c /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c
> /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c:151: warning:
> data definition has no type or storage class
> /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c:151: warning:
> type defaults to 'int' in declaration of 'USB_DECLARE_DRIVER'
> /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c:151: warning:
> parameter names (without types) in function declaration
> /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c:152: error:
> 'atausb_driver' undeclared here (not in a function)
> /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c:152: error:
> 'atausb_devclass' undeclared here (not in a function)
> /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c: In function
> 'atausb_attach':
> /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c:278: warning:
> implicit declaration of function 'atausb_detach'
> /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c:278: warning:
> nested extern declaration of 'atausb_detach'
> /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c: At top
> level:
> /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c:353: error:
> static declaration of 'atausb_detach' follows non-static declaration
> /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c:278: error:
> previous implicit declaration of 'atausb_detach' was here
> *** Error code 1
>
> I know it's not exactly critical as atausb is not built on default but
> would appreciate it if somebody could have a closer look at this.