Re: KSE was Re: open/close/ioctl api change?

From: Julian Elischer <julian_at_elischer.org>
Date: Mon, 25 Jun 2007 12:20:06 -0700
Danny Braniss wrote:
>> Danny Braniss wrote:
>>>> actually it's the struct thread *tp where my problems are,
>>>> this code works fine under 6.2, and did work till some days ago under current.
>>>>
>>>> static int
>>>> iscsi_open(struct cdev *dev, int flags, int otype, struct thread *td)
>>>> {
>>>> ...
>>>> 	debug(3, "td->td_proc=%p", td->td_proc);
>>>> 	debug(3, "td->td_proc->p_pid=%d pid=%d",
>>>> 	   td->td_proc->p_pid, curproc->p_pid);
>>>> ...
>>>>
>>>> the first debug prints out td->td_proc=0 and the next one panics.
>>> found the problem, 'option KSE' which is defined now in DEFAULTS,
>>> and i'm compiling a module! which does not include DEFAULTS!
>>>
>> even so it shouldnt' happen..
>>
> why? I'm compiling outside the source tree.
> I agree that it shouldn't, specially, since it took me a long
> time to find the problem :-), but I can't see how config options
> can be exported. Unless, the make file is made aware of the KERNCONF file.

there should be no place in the source at any time where a thread 
that is not on the free list could have a td_proc of NULL.
it doesn't matter about where a module came from etc.. the fact that
it happened is a bug somewhere.

> 
> 	danny
> 
Received on Mon Jun 25 2007 - 17:20:01 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:13 UTC