Re: [HEADSUP] ACPI-CA 20070126 import

From: Eygene Ryabinkin <rea-fbsd_at_codelabs.ru>
Date: Tue, 20 Mar 2007 10:06:11 +0300
Jung-uk, Nate, good day.

Mon, Mar 19, 2007 at 06:00:41PM -0700, Nate Lawson wrote:
>
> > I think it's not the acpi-ca patch, it's the recent acpi_ec.c change.
> > Try it with rev 1.68 of that file.
> > 
> 
> Or better, try with rev 1.71 that I just committed.  Fixed a bug where
> we weren't re-enabling the GPE, which could cause exactly this issue.

Nate, you're completely right: I've applied the 1.70 -> 1.71 patch
on top of the Jung-uk's one and it enabled the backlight controls
to work again. But the "queued" behaviour were still there.

Mon, Mar 19, 2007 at 03:38:30PM -0400, Jung-uk Kim wrote:
> > As a quick test, can you try this?
> 
> --- src/sys/dev/acpica/Osd/OsdSchedule.c
> +++ src/sys/dev/acpica/Osd/OsdSchedule.c
>  	pri = 5;
>  	break;
>      case OSL_NOTIFY_HANDLER:
> -	pri = 3;
> +	pri = 15;
>  	break;
>      case OSL_DEBUGGER_THREAD:
>  	pri = 0;

Jung-uk, and this change enabled the backlignt to go up or down
after the second press of any F-button, so the "event queue" length
got down to one. Again, your patch was applied to the yesterday's
clean FreeBSD HEAD and the Nate's one for the acpi_ec.c 1.70 ->
1.71 was applied on top of it.

> BTW, it is not really a patch, i.e., I just typed it in. :-) All I 
> want you to test is to change 3 -> 15.
> 
> I hope I didn't confuse you.

No, you're not confused me at all -- I am doing such "patches" almost
regularily ;))

Thank you both for your response and work!
-- 
Eygene
Received on Tue Mar 20 2007 - 06:06:18 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:06 UTC