Re: Improved INCLUDE_CONFIG_FILE

Wojciech A. Koszek wrote:
 > Alex Kozlov wrote:
 > > Wojciech A. Koszek wrote:
 > > > Current implementation of INCLUDE_CONFIG_FILE option has number of
 > > > issues. Including it in MAC or SMP configurations will bring only text
 > > > of this single file into the kernel file. We're not able to see
 > > > configuration of running ("live") kernel, which could be helpful while
 > > > tracking users' reports. You can't get easy to use file format, ready
 > > > for configuration process.
 > > > 
 > > > In my Perforce wkoszek_kconftxt branch:
 > > > 
 > > >   //depot/user/wkoszek/wkoszek_kconftxt/...
 > > > 
 > > > I brought some modifications to existing config(8) and added system
 > > > interface that would let us to see configuration of running kernel
 > > > (currently -- via kern.conftxt sysctl), as well as other kernel file
 > > > through config(8)'s -k option.
 > > 
 > > By the way, any plan to include INCLUDE_CONFIG_FILE in GENERIC?
 > 
 > I'd like to have this enabled by default, and I know there should be no
 > strong objections.

No objection from me, but please fix it so include files
are also included in the kernel.

Many of my kernel config files have only few lines (e.g.
"options SMP" and "include MYKERNEL").  Currently, the
INCLUDE_CONFIG_FILE feature only includes those two lines,
rendering that feature useless (and even potentially
dangerous if someone relies on his config to be in the
kernel).

Best regards
   Oliver

-- 
Oliver Fromme, secnetix GmbH & Co. KG, Marktplatz 29, 85567 Grafing b. M.
Handelsregister: Registergericht Muenchen, HRA 74606,  Geschäftsfuehrung:
secnetix Verwaltungsgesellsch. mbH, Handelsregister: Registergericht Mün-
chen, HRB 125758,  Geschäftsführer: Maik Bachmann, Olaf Erb, Ralf Gebhart

FreeBSD-Dienstleistungen, -Produkte und mehr:  http://www.secnetix.de/bsd

"File names are infinite in length, where infinity is set to 255 characters."
        -- Peter Collinson, "The Unix File System"