Re: geom_label problems when MS-DOS FS label is blank (all spaces)

From: Stefan Farfeleder <stefan_at_fafoe.narf.at>
Date: Sat, 12 May 2007 09:12:39 +0200
On Sat, May 12, 2007 at 10:51:25AM +0400, Yuriy Tsibizov wrote:
> > In this situation libdisk can't parse kern.geom.conftxt and sysinstall 
> > exits with BARF 171 message.
> 
>  It can be fixed with following patch. "all spaces" volume will be treated 
>  like a volume without label.
> 
>  Index: g_label_msdosfs.c
>  ===================================================================
>  RCS file: /home/ncvs/src/sys/geom/label/g_label_msdosfs.c,v
>  retrieving revision 1.6
>  diff -u -r1.6 g_label_msdosfs.c
>  --- g_label_msdosfs.c	30 Sep 2006 08:16:49 -0000	1.6
>  +++ g_label_msdosfs.c	12 May 2007 06:39:23 -0000
>  _at__at_ -200,7 +200,7 _at__at_
>   	}
> 
>   endofchecks:
>  -	for (i = size - 1; i > 0; i--) {
>  +	for (i = size - 1; i >= 0; i--) {
>   		if (label[i] == '\0')
>   			continue;
>   		else if (label[i] == ' ')

This won't work because i is unsigned.
Received on Sat May 12 2007 - 05:29:52 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:10 UTC