Re: Process for requesting reverting patch?

On 5/13/07 12:28 PM, Steve Kargl wrote:
> On Sun, May 13, 2007 at 09:24:35PM +0200, Dag-Erling Sm??rgrav wrote:
>> Steve Kargl <sgk_at_troutmask.apl.washington.edu> writes:
>>> On Sun, May 13, 2007 at 08:23:43PM +0200, Dag-Erling Sm??rgrav wrote:
>>>> Steve Kargl <sgk_at_troutmask.apl.washington.edu> writes:
>>>>> What is the formal process to get a recent commit to -current
>>>>> reverted?  Do I send email to core?
>>>> You start by talking to the person who did the commit.  That much should
>>>> be obvious.
>>> I would expect a committer, who changes something as important as
>>> the default shell in FreeBSD, to read the freebsd-current mailing
>>> list and the PR database.
>> I would expect a committer such as yourself to know that there are
>> better ways to approach this than posting to -current and threatening to
>> take the matter to core_at_.
>>
> 
> I'm not a committer to the FreeBSD repository.  I either 
> submit patches to fix problems or code for missing library
> routines.  In this particular case, reverting the tcsh
> import is the correct fix (IMHO).
> 
> I also didn't threaten anyone or anything.  I simply wanted 
> to know what the procedure is for getting code reverted.
> 

As the owner of the PR and the person that committed the recent tcsh I take it 
seriously when someone brings it to my attention. After the PR was assigned to 
me, I sent Steve two private emails on 5/7/2007 but with no response back. 
Given that it "works for me" on two different systems, I don't know what I 
could have done different. Below is the text from the second one.

Mark

On 5/7/07 12:15 PM, Mark Peek wrote:
 > On 5/7/07 8:39 AM, Mark Peek wrote:
 >> Thank you for bringing this to my attention. I just got back from a
 >> long business trip. I tried a quick repro but it worked fine for me so
 >> I'm getting up to date sources (buildworld, etc.) and will try again.
 >
 > I did the full rebuild and it still works fine for me:
 >
 > current32# echo $version
 > tcsh 6.15.00 (Astron) 2007-03-03 (i386-intel-FreeBSD) options
 > wide,nls,dl,al,kan,rh,color,filec
 > current32# cat hello.c
 > #include <stdio.h>
 >
 > int main(void) {
 >     printf("hello world\n");
 >     return 0;
 > }
 > current32# cc -o z -g hello.c
 > current32# which gdb
 > /usr/bin/gdb
 > current32# gdb z
 > GNU gdb 6.1.1 [FreeBSD]
 > Copyright 2004 Free Software Foundation, Inc.
 > GDB is free software, covered by the GNU General Public License, and you
 > are
 > welcome to change it and/or distribute copies of it under certain
 > conditions.
 > Type "show copying" to see the conditions.
 > There is absolutely no warranty for GDB.  Type "show warranty" for details.
 > This GDB was configured as "i386-marcel-freebsd"...
 > (gdb) run
 > Starting program: /root/bug/z
 > hello world
 >
 > Program exited normally.
 > (gdb) quit
 > current32#
 >
 > Have you seen any other reports of this issue? Could there be something
 > different or environmental with your system? I'm logging in as root and
 > using the stock .cshrc file.
 >
 > Mark
 >