Re: [PATCH] The current csup sources

Balwinder S Dheeman wrote:
> Hi,
> 
> I think, the manpage /usr/src/contrib/csup/csup.1 is dated and, or have not 
> been updated per current csup sources.

I don't quite understand this statement.  Unless I have missed
something, the current csup manual page matches the code and thus
seems up-to-date to me.  You are talking about updating the manual
page but your config.c patch actually changes a few default settings
and modifies the manual page accordingly.

To pick one example, you are changing the default base directory
from /usr/local/etc/cvsup to /var/db.  This seems to indicate you
somehow confused the default FreeBSD settings with the default csup
settings.  It's true that we changed the default FreeBSD supfiles
to use /var/db instead of /usr for the default base directory, but
this has nothing to do with the default csup settings.

I see no reason to change the default csup settings; it would just
break the supfiles for people who use the default settings.  So,
it would be a POLA violation.  It would also break compatibility
with CVSup since it would still use the old defaults.

Cheers,
Maxime