Re: EM and TSO

On 5/16/07, Sam Leffler <sam_at_errno.com> wrote:
> Jack Vogel wrote:
> > You mean other than net.inet.tcp.tso that is there now?
> >
> > On 5/16/07, Julian Elischer <julian_at_elischer.org> wrote:
> >> Jack Vogel wrote:
> >> > On 5/16/07, Andre Oppermann <andre_at_freebsd.org> wrote:
> >> >> Jack Vogel wrote:
> >> >> > I introduced a change yesterday that limited TSO to PCI Express
> >> >> > adapters, I did this more for avoidance rather than a bug fix, and
> >> >> > I'm not 100% sure its the right thing, so I thought I would poll
> >> >> > everyone, do you have a PCI-X adapter and are using TSO without
> >> >> > problems and wish to keep the support in?
> >> >>
> >> >> I'm using the dual-port PCI-X adapter and would like to keep
> >> >> using TSO on it.  There are a lot of those adapters out there
> >> >> in servers.  TSO is scheduled to be MFC'd really soon now and
> >> >> not having it work with em(4) on PCI-X would be quite limiting.
> >> >
> >> > OK, I'll put it back, you also answered a question I had, namely
> >> > the MFC of TSO :) I was hoping that got into 6.3.
> >> >
> >> > I have another bug I'm working on, will be a delta today or tomorrow
> >> > and I'll put it back to what it was.
> >> >
> >> > Jack
> >> > _______________________________________________
> >> > freebsd-net_at_freebsd.org mailing list
> >> > http://lists.freebsd.org/mailman/listinfo/freebsd-net
> >> > To unsubscribe, send any mail to "freebsd-net-unsubscribe_at_freebsd.org"
> >>
> >> give a sysctl to change the option.
>
> ifconfig can be used to ena/dis tso.  As I said before just give all the
> devices capable of tso the capability but only enable it by default on
> those devices you really know work (e.g. pci-e cards).  On other devices
> users that want to turn it on can do so with ifconfig.

I like this, good compromise. Thanks Sam :)

Should be coming into tree shortly.

Jack