Re: [Call for Testers] ACPI-CA 20071114

Jung-uk Kim wrote:
> On Friday 16 November 2007 04:41 pm, Pawel Worach wrote:
>> Jung-uk Kim wrote:
>>> Please test the following patch on -CURRENT:
>>>
>>> http://people.freebsd.org/~jkim/acpica-import-20071114.diff.gz
>> Hi,
>>
>> Looks good here on a ThinkPad T60 except for a new LOR.
>>
>> acpi_ibm0: <IBM ThinkPad ACPI Extras> on acpi0
>> lock order reversal: (sleepable after non-sleepable)
>>   1st 0xc083cb00 LED mtx (LED mtx) _at_ /usr/src/sys/dev/led/led.c:263
>>   2nd 0xc09cc304 ACPI IBM extras (ACPI IBM extras) _at_
>> /usr/src/sys/modules/acpi/acpi_ibm/../../../dev/acpi_support/acpi_i
>> bm.c:311 KDB: stack backtrace:
> 
> --- >8 --- SKIP --- >8 ---
> 
> I have to admit that I haven't really tested anything under 
> sys/dev/acpi_support because I don't own any of these laptops. :-(
> Anyway, can you test the following?
> 
> --- sys/dev/acpi_support/acpi_ibm.c     25 Oct 2007 17:30:18 -0000
> +++ sys/dev/acpi_support/acpi_ibm.c     16 Nov 2007 22:43:39 -0000
> _at__at_ -300,7 +300,7 _at__at_
>  	sc->led_busy = 1;
>  	sc->led_state = onoff;
>  
> -	AcpiOsExecute(OSL_NOTIFY_HANDLER, (void *)ibm_led_task, sc);
> +	acpi_queue_task(OSL_NOTIFY_HANDLER, (void *)ibm_led_task, sc);
>  }
>  
>  static void
> 

Yes, that fixed the LOR, thanks!

-- 
Pawel