Re: Now -stable is broken from undefined reference to `__mb_sb_limit'

Rong-en Fan wrote:
> On Nov 23, 2007 2:31 AM, Sean McNeil <sean_at_mcneil.com> wrote:
>   
>> Daniel Eischen wrote:
>>     
>>> On Wed, 21 Nov 2007, Sean McNeil wrote:
>>>
>>>       
>>>> Why was this stuff MFCd?
>>>>
>>>> cc -O2 -fno-strict-aliasing -pipe -g
>>>> -I/usr/src/kerberos5/libexec/ipropd-master/../../../crypto/heimdal/lib/krb5
>>>> -I/usr/src/kerberos5/libexec/ipropd-master/../../../crypto/heimdal/lib/asn1
>>>> -I/usr/src/kerberos5/libexec/ipropd-master/../../../crypto/heimdal/lib/roken
>>>> -I. -I/usr/local/include -DOPENLDAP=1 -DHAVE_CONFIG_H
>>>> -I/usr/src/kerberos5/libexec/ipropd-master/../../include -DINET6 -g
>>>> -L/usr/local/lib -Wl,-rpath,/usr/local/lib -o ipropd-master
>>>> ipropd_master.o -lkadm5srv -lhdb -lkrb5 -lroken
>>>> /usr/obj/usr/src/kerberos5/libexec/ipropd-master/../../lib/libvers/libvers.a
>>>> -lasn1 -lcrypto -lcrypt -lcom_err -lldap -llber
>>>> /usr/local/lib/libldap.so: undefined reference to `__mb_sb_limit'
>>>> *** Error code 1
>>>>
>>>> Stop in /usr/src/kerberos5/libexec/ipropd-master.
>>>>         
>>> I don't think it should have been MFC'd, but that ship has already
>>> sailed.  You're going to have to rebuild openldap first I think.
>>> Or perhaps build (kerberos) without LDAP.
>>>
>>>       
>> I agree, it should not have been MFC'd. If you think it through,
>> essentially it has both broken the -STABLE model and made 6-STABLE
>> useless. Rebuilding openldap doesn't help I would have to build without
>> kerberos, install, rebuild openldap, build again and install, then
>> rebuild all my ports.  This is not suppose to happen.
>>     
>
> Apply this then rebuild libc, it should be fine. I just sent it to re_at_
> for approval.
>
> RCS file: /home/ncvs/src/lib/libc/locale/none.c,v
> retrieving revision 1.13.2.2
> diff -u -r1.13.2.2 none.c
> --- lib/libc/locale/none.c      21 Nov 2007 01:31:48 -0000      1.13.2.2
> +++ lib/libc/locale/none.c      23 Nov 2007 11:17:04 -0000
> _at__at_ -181,6 +181,7 _at__at_
>  /* setup defaults */
>
>  int __mb_cur_max = 1;
> +int __mb_sb_limit = 256;
>  size_t (*__mbrtowc)(wchar_t * __restrict, const char * __restrict, size_t,
>      mbstate_t * __restrict) = _none_mbrtowc;
>  int (*__mbsinit)(const mbstate_t *) = _none_mbsinit;
>   
Thank you so much for resolving this. I really appreciate it.