Re: INSTKERNNAME= foolproof check

On 10/11/07, Dmitry Morozovsky <marck_at_rinet.ru> wrote:
> Colleagues,
>
> Today I successfully shoot myself in the foot by typing
>
> make installkernel KERNCONF=GENERIC INSTKERNNAME=
>
> instead of usual
>
> make installkernel KERNCONF=GENERIC INSTKERNNAME=GENERIC
>
> Empty INSTKERNNAME leads to wiping /boot completely - rather annoying,
> especially in my case, where I had some non-trivial (and, of course, no backups
> ;-) loader.conf
>
> What do you think about the following patch?
>
> Sincerely,
> D.Marck                                     [DM5020, MCK-RIPE, DM3-RIPN]
> [ FreeBSD committer:                                 marck_at_FreeBSD.org ]
> ------------------------------------------------------------------------
> *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck_at_rinet.ru ***
> ------------------------------------------------------------------------
>
>
> Index: Makefile.inc1
> ===================================================================
> RCS file: /home/ncvs/src/Makefile.inc1,v
> retrieving revision 1.588.2.1
> diff -u -r1.588.2.1 Makefile.inc1
> --- Makefile.inc1       11 Oct 2007 06:08:51 -0000      1.588.2.1
> +++ Makefile.inc1       11 Oct 2007 18:49:19 -0000
> _at__at_ -742,6 +742,10 _at__at_
>         _at_echo "ERROR: No kernel \"${KERNCONF}\" to install."; \
>         false
>  .endif
> +.if empty(INSTKERNNAME)
> +       _at_echo "ERROR: Kernel install directory is empty."; \
> +       false
> +.endif
>         _at_echo "--------------------------------------------------------------"
>         _at_echo ">>> Installing kernel"
>         _at_echo "--------------------------------------------------------------"
>

Seems like a very good idea to me.

-- 
Against stupidity the very gods Themselves contend in vain.
                                         Friedrich Schiller

Wes Peters
barnaclewes_at_gmail.com