Re: [PATCH] OsdSynch.c modernization

From: Cristian KLEIN <cristi_at_net.utcluj.ro>
Date: Fri, 21 Sep 2007 14:03:00 +0300
Jung-uk Kim wrote:
> On Tuesday 18 September 2007 05:23 pm, Cristian KLEIN wrote:
>> Jung-uk Kim wrote:
>>> I have rewritten sys/dev/acpica/Osd/OsdSynch.c to match the
>>> modern ACPI-CA and -CURRENT:
>>>
>>> http://people.freebsd.org/~jkim/acpica/OsdSynch.diff
>>>
>>> Major changes are:
>>>
>>> 1. Semaphore is reimplemented with convar(9) instead of mutex(9).
>>>
>>> 2. Semaphore with ACPI_WAIT_FOREVER option actually waits forever
>>> now.
>>>
>>> 3. Obsolete and/or hidden debugging knobs and macros are removed.
>>>
>>> 4. ACPI-CA introduced AcpiOs*Mutex() to complement
>>> AcpiOs*Semaphore():
>>>
>>> 	http://bugzilla.kernel.org/show_bug.cgi?id=6634
>>>
>>>    These functions are implemented and turned on by default.
>>>
>>> 5. Spinlock is reimplemented with sx lock and more closely
>>> implements the intended behaviour (e.g., save/restore
>>> interrupts).
>>>
>>> It is orthogonal to Nate's effort of rewriting acpi_ec.c but I'd
>>> like get more feedback *with* his last patch (revision D) because
>>> his patch will be committed sooner or later. ;-)
>>>
>>> Please test/review and let us know if there is any regression or
>>> not.
>> Sorry for not being able to test the patch. May I assume this will
>> fix:
>>
>> http://www.freebsd.org/cgi/query-pr.cgi?pr=114113
>> http://www.freebsd.org/cgi/query-pr.cgi?pr=114649
> 
> I believe my patch AND Nate's patch will fix the problem.

Hi,

I tested your patch and it works flawless. However, before applying your patch,
the "recursive lock on non-recursive mutex" did not occur either.
Received on Fri Sep 21 2007 - 09:03:08 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:17 UTC