Re: stack hogs in kernel

From: Roman Divacky <rdivacky_at_FreeBSD.org>
Date: Sat, 12 Apr 2008 20:16:01 +0200
On Sat, Apr 12, 2008 at 07:14:21PM +0100, Robert Watson wrote:
> 
> On Fri, 11 Apr 2008, Julian Elischer wrote:
> 
> >0xc05667e3 kldstat [kernel]:				2100
> >0xc07214f8 sendsig [kernel]:				1416
> >0xc04fb426 ugenread [kernel]:				1200
> >0xc070616b ipmi_smbios_identify [kernel]:		1136
> >0xc050bd26 usbd_new_device [kernel]:			1128
> >0xc0525a83 pfs_readlink [kernel]:			1092
> >0xc04fb407 ugenwrite [kernel]:				1056
> >0xc055ea33 prison_enforce_statfs [kernel]:		1044
> 
> This one, at least, is due to an issue Roman pointed out on hackers_at_ in the 
> last 24 hours -- a MAXPATHLEN sized buffer on the stack.  Looks like 
> pfs_readlink() has the same issue.

I plan to look at some of the MAXPATHLEN usage... I guess we can shave a few
tens of KBs from the kernel (static size and runtime size).

roman
Received on Sat Apr 12 2008 - 16:16:35 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:29 UTC