Unnecessary verbose boot messages: ath_hal

From: Ivan Voras <ivoras_at_freebsd.org>
Date: Fri, 18 Apr 2008 11:30:41 +0200
Is there any significant reason why ath_hal displays its banner on load
even if the hardware isn't present? I recall hptrr has also done it but
apparently it's fixed now, so I'm attaching a patch for ath to place the
banner under bootverbose.



--- ath_old/ah_osdep.c	2008-04-18 11:22:53.000000000 +0200
+++ ath/ah_osdep.c	2008-04-18 11:23:48.000000000 +0200
_at__at_ -411,13 +411,15 _at__at_
 
 	switch (type) {
 	case MOD_LOAD:
-		printf("ath_hal: %s (", ath_hal_version);
-		sep = "";
-		for (i = 0; ath_hal_buildopts[i] != NULL; i++) {
-			printf("%s%s", sep, ath_hal_buildopts[i]);
-			sep = ", ";
+		if (bootverbose) {
+			printf("ath_hal: %s (", ath_hal_version);
+			sep = "";
+			for (i = 0; ath_hal_buildopts[i] != NULL; i++) {
+				printf("%s%s", sep, ath_hal_buildopts[i]);
+				sep = ", ";
+			}
+			printf(")\n");
 		}
-		printf(")\n");
 		return 0;
 	case MOD_UNLOAD:
 		return 0;
Received on Fri Apr 18 2008 - 07:30:52 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:30 UTC