Concerns about .../src/lib/libc/gen/glob.c in 8-CURRENT

From: Garrett Cooper <yanefbsd_at_gmail.com>
Date: Tue, 29 Apr 2008 09:20:26 -0700
Hi again all,
      Not sure who yanked up the warnings or if gcc is in a particularly bad
mood but it appears that compiling this source file is now failing on
8-CURRENT for me with the following message:

cc -fpic -DPIC -O3 -pipe -fno-strict-aliasing -march=prescott
-I/devel/ncvs/src/lib/libc/include -I/devel/ncvs/src/lib/libc/../../include
-I/devel/ncvs/src/lib/libc/i386 -D__DBINTERFACE_PRIVATE
-I/devel/ncvs/src/lib/libc/../../contrib/gdtoa
-I/usr/obj/devel/ncvs/src/lib/libc -I/devel/ncvs/src/lib/libc/resolv
-DPOSIX_MISTAKE -I/devel/ncvs/src/lib/libc/locale -DBROKEN_DES -DPORTMAP
-DDES_BUILTIN -I/devel/ncvs/src/lib/libc/rpc -DSYMBOL_VERSIONING
-Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized
-Wno-pointer-sign -c /devel/ncvs/src/lib/libc/gen/glob.c -o glob.So
/devel/ncvs/src/lib/libc/gen/glob.c: In function 'globexp1':
/devel/ncvs/src/lib/libc/gen/glob.c:242: warning: initialization discards
qualifiers from pointer target type
*** Error code 1

      I didn't remember what the error was but looked it up and it appears
that there was some concern about casting and modify the reference that a
const pointer was pointing to.
      I looked over the source and although I was concerned about the code
in globexp2 (in particular the reassigning of const pointers and
incrementing going on), I didn't see anything wrong in globexp1. I could
have totally missed something non-obvious though...
Thanks,
-Garrett
Received on Tue Apr 29 2008 - 14:20:28 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:30 UTC