Re: svn commit: r185482 - head/sys/dev/ath/ath_rate/sample

Jille Timmermans wrote:
> Vladimir Grebenschikov wrote:
>>       * On Sun, 2008-11-30 at 19:06 +0000, Sam Leffler wrote:
>>  
>>> Author: sam
>>> Date: Sun Nov 30 19:06:35 2008
>>> New Revision: 185482
>>> URL: http://svn.freebsd.org/changeset/base/185482
>>>
>>> Log:
>>>   Major overhaul:
>>>   o eliminate private state indexed by 802.11 rate codes; use the hal's
>>>     rate tables directly to get the same info
>>>   o calculate a mask of operational rates to optimize lookups and 
>>> checks
>>>     (instead of using for loops and similar)
>>>   o optimize size bin operations
>>>   o ignore rates marked as "do not use" in the hal phy tables
>>>   o fix bug that caused upshifting to break in 11g once the rate 
>>> dropped
>>>     below 11Mb/s
>>>   o add more intelligent multi-rate tx schedules
>>>   o add support for 1/2 and 1/4 width channels
>>>   o add dev.ath.X.sample_stats sysctl to dump runtime statistics to 
>>> the console
>>>     (needs to go up to a user app)
>>>   o export more tuning knobs via sysctls (still a couple of magic 
>>> constants)
>>>     
>>
>> Looks like, after that commit, I can't use if_ath loaded as module any
>> more:
>>
>> # kldload /boot/kernel/ath_rate.ko
>> kldload: can't load /boot/kernel/ath_rate.ko: No such file or directory
>> # dmesg | tail -n1 link_elf: symbol ath_hal_computetxtime undefined
>> #
>>
>> Yes, I've read UPDATING entry 20081130.
>> But I have no ath_hal entry in my kernel config, I've loaded ath as 
>> KLDs.
>>
>> How to fix that problem ?
>>   
> I have the same problem if I load it with kernel modules.
> If I compile it into my kernel (with ath, ath_hal and that option 
> (can't remember it for now)) my system paniced during boot.
> I can't get a coredump, but I will try getting a stacktrace with ddb 
> tonight.
>
> My Atheros (2413 iirc) wasn't usable before the import (did some 
> printf's during boot, but I couldn't get ath0 showing up in ifconfig)
> I am willing to help debugging if needed.
Where is the PR?

    Sam