Re: RTL8102E (if_re) doesn't work with -current

From: Bruce Cran <bruce_at_cran.org.uk>
Date: Wed, 17 Dec 2008 23:32:34 -0500
On Wed, Dec 17, 2008 at 06:19:34PM +0900, Pyun YongHyeon wrote:
> 
> Oops, please forget previous patch and use attached patch instead.
> 
> Index: if_re.c
> ===================================================================
> --- if_re.c	(revision 186214)
> +++ if_re.c	(working copy)
> _at__at_ -2681,7 +2681,14 _at__at_
>  	ifp->if_drv_flags |= IFF_DRV_RUNNING;
>  	ifp->if_drv_flags &= ~IFF_DRV_OACTIVE;
>  
> -	sc->rl_flags &= ~RL_FLAG_LINK;
> +	/*
> +	 * XXX
> +	 * Since we don't request reset for rlphy(4), it's necessary
> +	 * to set initial (fake) link state. Otherwise re(4) wouldn't
> +	 * work as link state 'UP' event from mii(4) may not be
> +	 * delivered if the valid link was already established.
> +	 */
> +	sc->rl_flags |= RL_FLAG_LINK;
>  	sc->rl_watchdog_timer = 0;
>  	callout_reset(&sc->rl_stat_callout, hz, re_tick, sc);
>  }

With that patch applied (I kept the changes to rlphy.c too) the network is 
now working again.  Thanks!

-- 
Bruce Cran

Received on Thu Dec 18 2008 - 03:49:38 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:39 UTC