Re: Symbol versioning errors in libthr

From: Daniel Eischen <deischen_at_freebsd.org>
Date: Sun, 3 Feb 2008 12:00:04 -0500 (EST)
On Sun, 3 Feb 2008, Dag-Erling Smørgrav wrote:

> Here's an excerpt from the RELENG_7 vs HEAD diff of libthr's symbol map:
>
> --- pthread.map	13 May 2007 14:12:39 -0000	1.18
> +++ pthread.map	20 Dec 2007 04:32:28 -0000	1.21
> _at__at_ -84,9 +84,13 _at__at_
> 	pthread_multi_np;
> 	pthread_mutex_destroy;
> 	pthread_mutex_getprioceiling;
> +	pthread_mutex_getspinloops_np;
> +	pthread_mutex_getyieldloops_np;
> 	pthread_mutex_init;
> 	pthread_mutex_lock;
> 	pthread_mutex_setprioceiling;
> +	pthread_mutex_setspinloops_np;
> +	pthread_mutex_setyieldloops_np;
> 	pthread_mutex_timedlock;
> 	pthread_mutex_trylock;
> 	pthread_mutex_unlock;
>
> These functions are all in FBSD_1.0, but they were introduced after the
> branch and never MFCed, so if I understand how we've implemented symbol
> versioning, they should be in FBSD_1.1.
>
> Unless someone argues credibly for keeping them in FBSD_1.0, I will move
> them to FBSD_1.1 in a few days.

Yes, I believe you are correct in how we've decided to implement
the version namespace.  After a branch from HEAD (e.g., after 7-
was branched), we increment the namespace and new symbols and
ABI changes get added to the new namespace.

-- 
DE
Received on Sun Feb 03 2008 - 16:00:12 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:26 UTC