allow vs. usermount [Re: ZFS patches.]

On Sunday 27 July 2008 14:54:13 Pawel Jakub Dawidek wrote:
> If you have any questions, please use mailing lists
> (freebsd-fs_at_FreeBSD.org would be the best).

Short exercise:
| $ whoami
| mlaier
| $ zfs list
| NAME          USED  AVAIL  REFER  MOUNTPOINT
| tank          104K   228G    19K  /tank
| tank/mlaier    18K   228G    18K  /tank/mlaier
| $ zfs allow tank/mlaier
| -------------------------------------------------------------
| Local+Descendent permissions on (tank/mlaier)
|         user mlaier create,destroy,mount,snapshot
| -------------------------------------------------------------
| $ zfs create tank/mlaier/test
| cannot mount 'tank/mlaier/test': Insufficient privileges
| filesystem successfully created, but not mounted

This is obviously due to the check in vfs_mount.c patched line 851:

	if (jailed(td->td_ucred) || usermount == 0) {

the question is, should this be tuned to allow for the finer grained zfs 
permissions to take effect or will we force usermount to use zfs allow mount?

-- 
/"\  Best regards,                      | mlaier_at_freebsd.org
\ /  Max Laier                          | ICQ #67774661
 X   http://pf4freebsd.love2party.net/  | mlaier_at_EFnet
/ \  ASCII Ribbon Campaign              | Against HTML Mail and News