Re: cpuctl(formely devcpu) patch test request

On Fri, Jun 06, 2008 at 02:09:27AM +0400, Stanislav Sedov wrote:
> On Thu, 5 Jun 2008 21:55:39 +0100
> Rui Paulo <rpaulo_at_FreeBSD.org> mentioned:
> 
> > A couple comments:
> > 1) Do you plan to MFC this ? For what older versions of FreeBSD will devcpu be
> > shipped?
> 
> In fact, I plan to MFC that to all supported FreeBSD versions (6, 7),
> as changes are minimal. Until that those versions will be supported
> by sysutils/devcpu port.

Ok.

> > 
> > 2) in cpuctl_modevent(): perhaps it's better to return ENOMEM instead of
> > ENOSYS if malloc() fails and ENXIO instead of ENOSYS if MSR functionality is
> > not present
> 
> I fully agree on ENOMEM (thanks for noticing that), while I think that
> returning ENOSYS for MSR-less systems is more correct, as it states that
> required functionality isn't implemented for this hardware.

Agreed.

> > 3) I don't mean to impose, but this code needs some small style cleanup,
> >    namely: characters above the 80 column, second level indents are four
> >    spaces"
> 
> Good catch! Fixed.

Good, thanks.
-- 
Rui Paulo