Re: PUC rewrite

On Jun 6, 2008, at 5:59 AM, Mike Tancsa wrote:

> I have been starting to take a look at moving some of our embedded  
> platforms to RELENG_7 and noticed that support for the 3Com PCI  
> cards are broken.  Previously, in pucdata.c, they were defined as
>
>       /* US Robotics (3Com) PCI Modems */
>        {   "US Robotics (3Com) 3CP5609 PCI 16550 Modem",
>            {   0x12b9, 0x1008, 0,      0       },
>            {   0xffff, 0xffff, 0,      0       },
>            {
>                { PUC_PORT_TYPE_COM, 0x10, 0x00, COM_FREQ },
>            },
>        },
>
>
> However, in the newer version they are not there, and uart is not  
> picking up the device.

Since this is a single-port UART, puc(4) is not supposed to have
support for it. The uart(4) can handle it without needing puc(4).
However, that implies that uart(4) needs to have the support for
it and I guess that's not present.

> In the new re-write, what is the proper way to add support for  
> devices no longer recognized ?

Add the PCI Ids to uart_bus_pci.c. Keep the list of Ids sorted,
because it's assumed by uart_pci_match().

If you can send me a patch, I'll commit to head and stable.

FYI,

-- 
Marcel Moolenaar
xcllnt_at_mac.com