Re: CFT: CVSMode for csup with MD5 check

On lør, jun 07, 2008 at 10:18:05am +0200, Kris Kennaway wrote:
> Ulf Lilleengen wrote:
> > Hello,
> > 
> > As a followup to my previous patch on csup, I've tried to do some fixes to
> > RCS-files. However, instead of doing major workarounds in csup to handle
> > files which does not behave correctly to RCS, I implemented MD5 check of RCS
> > content. This means that the MD5 sum from cvsupd is checked against the
> > actual RCS content (which is different from a normal MD5 check, because
> > only the content is compared), and if it's not correct, a fixup of the file
> > will be sent, thus making sure that the contents are correct. I hope some of
> > you are able to test this. 
> > 
> > There are still a few issues with cvsmode:
> > - Not correct entries in status file.
> > - I get unnatural high memory usage.
> > 
> > Patches here:
> > http://people.freebsd.org/~lulf/patches/csup/csup_2008-05-31_CURRENT.diff
> > and
> > http://people.freebsd.org/~lulf/patches/csup/csup_2008-05-31_RELENG_7.diff
> > 
> 
> This doesn't compile.  There are a bunch of warnings, and rcsfile.c is 
> missing from Makefile, but there is an undefined reference:
> 
> rcsfile.o(.text+0x1d32): In function `rcsfile_frompath':
> : undefined reference to `rcsparse_run'
> *** Error code 1
> 
Sorry, I probably didn't test the patch correctly. These patches now works
for me on a 7.0 and CURRENT tree at least:

http://people.freebsd.org/~lulf/patches/csup/csup_2008-06-07_RELENG_7.diff
http://people.freebsd.org/~lulf/patches/csup/csup_2008-06-07_CURRENT.diff

-- 
Ulf Lilleengen