Re: CFT: BSD-licensed grep [Fwd: cvs commit: ports/textproc/bsdgrep Makefile distinfo]

From: Andrey Chernov <ache_at_nagual.pp.ru> Date: Wed, 25 Jun 2008 01:30:18 +0400 · This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:32 UTC

On Wed, Jun 25, 2008 at 01:04:20AM +0400, Andrey Chernov wrote:
> >         if ((s = mbstowcs(NULL, f->base, 0)) == -1)
> >                 return (0);
> 
> The same here. Check EILSEQ and return 1

BTW, do you realyze that this code malloc()s _whole_file_ into memory 
(which not fits for very big files)?
Non-localized old code use mmap, so don't actually malloc() it.
Doe to that perhaps whole mmfile.c should be not used and removed.

-- 
http://ache.pp.ru/